Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help for testing #49

Closed
bayaraa opened this issue Apr 15, 2023 · 34 comments
Closed

Help for testing #49

bayaraa opened this issue Apr 15, 2023 · 34 comments
Labels
help wanted Extra attention is needed

Comments

@bayaraa
Copy link
Owner

bayaraa commented Apr 15, 2023

Hello guys. D2GL v1.1.1 has quite bit changes in terms of rendering and it needs to testing.
On my 3pcs with intel iGpu(iris 550, HD4600, Macbook M1) working with no issues. But it might have issues with dedicated gpus.
So if you have such hardware(Nvidia, AMD, Intel dedicated gpu) please test it (preferably on plain D2) and report here.
Thanks.

@bayaraa bayaraa added the help wanted Extra attention is needed label Apr 15, 2023
@skylight102
Copy link

skylight102 commented Apr 15, 2023

I wonder if Jarcho who has made a fork on D2DX would be willing to help?

https://github.com/Jarcho/d2dx

@KevTheDankest
Copy link

error

Received this error just being idle in Harrogath

@xijin1337
Copy link

no problem, you have my sword

@xijin1337
Copy link

xijin1337 commented Apr 16, 2023

for now no problems
dedicated cpu+gpu amd here

@weili0677
Copy link

weili0677 commented Apr 17, 2023

The "Out of memory" error will happened with TP very fast in game.and will show #800 msg in game, Out of memory in d2xxxxxx.txt log file.

1.04 is fine.and 1.04 so stable then 1.1.1.

and 1.1.1 can't open the PRESPECTIVE in VEDIO OPTIONS with Nvidia 3090 card,1.04 is good.

@xijin1337
Copy link

xijin1337 commented Apr 20, 2023

everything still works flawlessly
(on ddraw the game runs noticeably smoother than before)

@Ognyan1987
Copy link

Ognyan1987 commented Apr 21, 2023

The "Out of memory" error will happened with TP very fast in game.and will show #800 msg in game, Out of memory in d2xxxxxx.txt log file.

1.04 is fine.and 1.04 so stable then 1.1.1.

and 1.1.1 can't open the PRESPECTIVE in VEDIO OPTIONS with Nvidia 3090 card,1.04 is good.

So using older release will fix the out of memory error?
Asking cause on 1.1.1 revision i get mas crashes and out of memory errors

@weili0677
Copy link

The "Out of memory" error will happened with TP very fast in game.and will show #800 msg in game, Out of memory in d2xxxxxx.txt log file.
1.04 is fine.and 1.04 so stable then 1.1.1.
and 1.1.1 can't open the PRESPECTIVE in VEDIO OPTIONS with Nvidia 3090 card,1.04 is good.

So using older release will fix the out of memory error?

Yes.

@Ognyan1987
Copy link

The "Out of memory" error will happened with TP very fast in game.and will show #800 msg in game, Out of memory in d2xxxxxx.txt log file.
1.04 is fine.and 1.04 so stable then 1.1.1.
and 1.1.1 can't open the PRESPECTIVE in VEDIO OPTIONS with Nvidia 3090 card,1.04 is good.

So using older release will fix the out of memory error?

Yes.

Just tested 1.4 , no a single error for more than a hour of playing!Any idea how to prevnt moue lock inside the game window?
1.4 does no have option t disable / enable cursor lock!

@weili0677
Copy link

The "Out of memory" error will happened with TP very fast in game.and will show #800 msg in game, Out of memory in d2xxxxxx.txt log file.
1.04 is fine.and 1.04 so stable then 1.1.1.
and 1.1.1 can't open the PRESPECTIVE in VEDIO OPTIONS with Nvidia 3090 card,1.04 is good.

So using older release will fix the out of memory error?

Yes.

Just tested 1.4 , no a single error for more than a hour of playing!Any idea how to prevnt moue lock inside the game window? 1.4 does no have option t disable / enable cursor lock!

You can download the sourcecode and edit code by yourself.

@Ognyan1987
Copy link

Ognyan1987 commented Apr 21, 2023

The "Out of memory" error will happened with TP very fast in game.and will show #800 msg in game, Out of memory in d2xxxxxx.txt log file.
1.04 is fine.and 1.04 so stable then 1.1.1.
and 1.1.1 can't open the PRESPECTIVE in VEDIO OPTIONS with Nvidia 3090 card,1.04 is good.

So using older release will fix the out of memory error?

Yes.

Just tested 1.4 , no a single error for more than a hour of playing!Any idea how to prevnt moue lock inside the game window? 1.4 does no have option t disable / enable cursor lock!

You can download the sourcecode and edit code by yourself.

Got absolutely no idea man how to do that!

@Ognyan1987
Copy link

Ognyan1987 commented Apr 21, 2023

@bayaraa First i want to thanks you for the effort u put on that project it is absolutely amazing , glad that there are still people who try to update the game to look more modern!!

So i made 1-2 topics with the problems i get with revision 1.1.1 since i missread that u already opened a topic for asking for help about if any issue with revision 1.1.1 ! Posting here again cause i wanted to see the difference between revision 1.4 and 1.1.1 and 1.4 runs waaay more smoother ! Using 1.4 right now untill 1.1.1 feels as stable as 1.4!

With 1.1.1 i get mass errors and crashes and alot of Out of memory stuff plus lag spikes which are not usual
1.1.1 Issues are ! This doesnt happen with revision 1.4

- Getting black spots in inventory or at vendor trade tabs when enabling Bloom Effect or Colour Grading! This doesnt happen with revison 1.4
- Crashing alot with different errors and alot of out of memory erros within 30-45 min of playtime no matter if private server or Single player ( My PC specs are enough high and PC itself is not the case) ! This doesnt happen with revision 1,4
- Alot of lag spikes which again is not due to my PC specs but revision 1.1.1 ! This doesnt happen with revision 1.4
- ingame cursor is not active when i switching back to game while i was alt+tab , i need to double click the D2 Window ( while on windose mode) so cursor to get active again , yes is minor bug but it annoying hopefully u could fix ! Happen with revision 1,4 too

  • Opening the game with revision 1.1.1 with -ns from a custom loader opens the game with black screen and it stays so! This bug does not exist on revision 1.4

I think those are the bug i get on 1.1.1!
My pc specs are:

RAM 64 GB
CPU AMD Ryzen 7
GPU GTX 1070TI
As i said my PC doesnt feel anything when loading the game right now with revision 1.4 , not a single lag spike or any of the above issues, once i siwtch back to 1.1.1 it feels like my PC gets hard times but looking at the benchmark it stays normal!

@xijin1337
Copy link

xijin1337 commented Apr 24, 2023

still no issues
EDIT: Project Diablo II with PlugY on dedicated AMD FX + AMD RX470

@skylight102
Copy link

What mod

still no issues
dedicated AMD FX + AMD RX470

Which mod? Or just normal d2?

@xijin1337
Copy link

xijin1337 commented Apr 24, 2023

@skylight102
Sorry,
Project Diablo II + PlugY
(from today I will be testing Diablo II LoD 1.13c without PlugY with a classic character)

@oGkspAz
Copy link

oGkspAz commented Apr 24, 2023

Basemod comes with its own game.exe depending on which d2 version it is. So far I have not been able to get it to run with d2gl.
I double click the -3dfx shortcut and it thinks for a split second and doesn't run. I am not sure how I can help with what's causing it, Just mentioning my experience thus far. (Works find with vanilla)
i5 6600
16gb RAM
1070 gtx

@skylight102
Copy link

Basemod comes with its own game.exe depending on which d2 version it is. So far I have not been able to get it to run with d2gl.
I double click the -3dfx shortcut and it thinks for a split second and doesn't run. I am not sure how I can help with what's causing it, Just mentioning my experience thus far. (Works find with vanilla)
i5 6600
16gb RAM
1070 gtx

Can you not juat add the basemod dll to the d2gl.ini?

@xijin1337
Copy link

xijin1337 commented Apr 24, 2023

@oGkspAz
it doesn't matter which loader you use.
first do a graphics test, then select a D2GL mode, then add " -3dfx" or " -ddraw" to the shortcut
d2vidtst.zip
(launch d2vidtst.exe with compatibility mode with windows xp)

below screenshot of working d2 lod 1.13c + basemod + d2gl (tested with DDRAW and 3DFX modes)
working basemod with d2gl

@bayaraa
Copy link
Owner Author

bayaraa commented Apr 26, 2023

@weili0677 @oGkspAz @Ognyan1987 @KevTheDankest
glide3x.zip
could you try this with -3dfx -log on your nvidia gpu pc. seems crash fixed but needs multiple confirmation.

@xijin1337 please check if it's still no issue with on your amd.

@weili0677
Copy link

@weili0677 @oGkspAz @Ognyan1987 @KevTheDankest glide3x.zip could you try this with -3dfx -log on your nvidia gpu pc. seems crash fixed but needs multiple confirmation.

@xijin1337 please check if it's still no issue with on your amd.

Thank you.but I modify your sourcecode to support chinese fonts. so this file maybe I can't help to test.

@weili0677
Copy link

@weili0677 @oGkspAz @Ognyan1987 @KevTheDankest glide3x.zip could you try this with -3dfx -log on your nvidia gpu pc. seems crash fixed but needs multiple confirmation.

@xijin1337 please check if it's still no issue with on your amd.

but my friend @skylight102 said this version has fixed the crash.

@bayaraa
Copy link
Owner Author

bayaraa commented Apr 26, 2023

but my friend @skylight102 said this version has fixed the crash.

yeah. but needs at least 2,3 people confirmation to finalize and release :D

@bayaraa bayaraa mentioned this issue Apr 26, 2023
@skylight102
Copy link

skylight102 commented Apr 27, 2023

but my friend @skylight102 said this version has fixed the crash.

yeah. but needs at least 2,3 people confirmation to finalize and release :D

One thing I noticed Bayaraa, is that I, and probably many of us, have ddraw.ini files which vary per user.

I notice this is not automatically generated, but perhaps it should be?

I removed the .ini and tried your old version btw, but still issues with large memory consumption.

In particular, I wondered about the following line:

; Force CPU0 affinity, avoids crashes/freezing, might have a performance impact
singlecpu=true

Should this be set to true or false? Does it even matter? : )


; cnc-ddraw - https://github.com/CnCNet/cnc-ddraw - https://cncnet.org

; ### NOTE TO PROJECT DIABLO 2 PLAYERS ###

; To enable upscaling via shaders in -fullscreen mode- just set 'fullscreen=true' and 'windowed=false'

; To enable upscaling via shaders in -borderless mode- just set 'fullscreen=true' and 'windowed=true'

; To enable upscaling via shaders in -windowed mode- just set 'fullscreen=false' and 'windowed=true' then start the game and resize your window or set 'width=' and 'height=' to the desired window size

[ddraw]
; ### Optional settings ###
; Use the following settings to adjust the look and feel to your liking

; Stretch to custom resolution, 0 = defaults to the size game requests
width=1632
height=916

; Override the width/height settings shown above and always stretch to fullscreen
; Note: Can be combined with 'windowed=true' to get windowed-fullscreen aka borderless mode
fullscreen=false

; Run in windowed mode rather than going fullscreen
windowed=true

; Maintain aspect ratio - (Requires 'handlemouse=true')
maintas=true

; Windowboxing / Integer Scaling - (Requires 'handlemouse=true')
boxing=false

; Real rendering rate, -1 = screen rate, 0 = unlimited, n = cap
; Note: Does not have an impact on the game speed, to limit your game speed use 'maxgameticks='
maxfps=0

; Vertical synchronization, enable if you get tearing - (Requires 'renderer=auto/opengl/direct3d9')
; Note: vsync=true can fix tearing but it will cause input lag
vsync=false

; Automatic mouse sensitivity scaling - (Requires 'handlemouse=true')
; Note: Only works if stretching is enabled. Sensitivity will be adjusted according to the size of the window
adjmouse=false

; Preliminary libretro shader support - (Requires 'renderer=opengl') https://github.com/libretro/glsl-shaders
; 2x scaling example: https://imgur.com/a/kxsM1oY - 4x scaling example: https://imgur.com/a/wjrhpFV
shader=Shaders\cubic.glsl

; Window position, -32000 = center to screen
posX=102
posY=83

; Renderer, possible values: auto, opengl, gdi, direct3d9 (auto = try direct3d9/opengl, fallback = gdi)
renderer=opengl

; Developer mode (don't lock the cursor)
devmode=true

; Show window borders in windowed mode
border=true

; Save window position/size/state on game exit and restore it automatically on next game start
; Possible values: 0 = disabled, 1 = save to global 'ddraw' section, 2 = save to game specific section
savesettings=1

; Should the window be resizeable by the user in windowed mode?
resizeable=true

; Enable C&C video resize hack - Stretches C&C cutscenes to fullscreen
vhack=false

; Enable linear (D3DTEXF_LINEAR) upscaling filter for the direct3d9 renderer (16 bit color depth games only)
d3d9linear=true

; ### Compatibility settings ###
; Use the following settings in case there are any issues with the game

; Hide WM_ACTIVATEAPP and WM_NCACTIVATE messages to prevent problems on alt+tab
noactivateapp=false

; Max game ticks per second, possible values: -1 = disabled, -2 = refresh rate, 0 = emulate 60hz vblank, 1-1000 = custom game speed
; Note: Can be used to slow down a too fast running game, fix flickering or too fast animations
; Note: Usually one of the following values will work: 60 / 30 / 25 / 20 / 15 (lower value = slower game speed)
maxgameticks=0

; Gives cnc-ddraw full control over the mouse cursor (required for adjmouse/boxing/maintas)
; Note: Set this to 'false' if your cursor becomes invisible at some places in the game
handlemouse=true

; Windows API Hooking, Possible values: 0 = disabled, 1 = IAT Hooking, 2 = Microsoft Detours, 3 = IAT+Detours Hooking (All Modules), 4 = IAT Hooking (All Modules)
; Note: Change this value if windowed mode or upscaling isn't working properly
; Note: 'hook=2' will usually work for problematic games, but 'hook=2' must be combined with renderer=gdi
hook=4

; Force minimum FPS, possible values: 0 = disabled, -1 = use 'maxfps=' value, 1-1000 = custom FPS
; Note: Set this to a low value such as 5 or 10 if some parts of the game are not being displayed (e.g. menus or loading screens)
minfps=0

; Disable fullscreen-exclusive mode for the direct3d9/opengl renderers
; Note: Can be used in case some GUI elements like buttons/textboxes/videos/etc.. are invisible
nonexclusive=false

; Force CPU0 affinity, avoids crashes/freezing, might have a performance impact
singlecpu=true

@bayaraa
Copy link
Owner Author

bayaraa commented Apr 27, 2023

That's cnc-ddraw's config file lol 🤦. It's nothing to do with D2GL.
Both D2GL's ddraw.dll/glide3x.dll reads same config file d2gl.ini. And since i only provide custom glide3x.dll for testing, ddraw.dll is still old v1.1.1 which has still memory leak bug.

@skylight102
Copy link

skylight102 commented Apr 27, 2023

That's cnc-ddraw's config file lol 🤦. It's nothing to do with D2GL.
Both D2GL's ddraw.dll/glide3x.dll reads same config file d2gl.ini. And since i only provide custom glide3x.dll for testing, ddraw.dll is still old v1.1.1 which has still memory leak bug.

As someone who is not a developer, why not call it cncddraw.ini then? 🤷‍♂️

Sorry! Only trying to help :(

@bayaraa
Copy link
Owner Author

bayaraa commented Apr 27, 2023

It's ok :)
Probably because he wants to both dll and ini file together in file list.
I would do that too if D2GL had only 1 dll. But it has 2 dlls(glide3x/ddraw) share same config file so i choose d2gl.ini instead.

@Ognyan1987
Copy link

Ognyan1987 commented Apr 27, 2023

@weili0677 @oGkspAz @Ognyan1987 @KevTheDankest glide3x.zip could you try this with -3dfx -log on your nvidia gpu pc. seems crash fixed but needs multiple confirmation.

@xijin1337 please check if it's still no issue with on your amd.

@bayaraa Running the game with the latest glide u provided for 2 hours , no craah yet , with revision 1.1.1 i couldnt get even 1 hour playtime :) ! will list down what are the other things which are fixed or not fixed with this new version + suggestions for some enchancemnts !

Not Fixed # I - Getting black spots in inventory or at vendor trade tabs when enabling Bloom Effect or Colour Grading! - **This bug doesnt exist in revision 1.4 , It seemed to be Fixed in the first launch of the game with the latest glide you provided
EDIT : The black spots in the stash and in the vendor trade screen appeared again after i relaunched the game with colour grading and bloom effect enabled , i edited my previous post with the bugs
Here is the d2gl log with the black spots issue
d2gl.log
blak spoooot1
black spoot vendoor too

Fixed # II - Crashing alot with different errors and alot of out of memory erros within 30-45 min of playtime no matter if private server or Single player ( My PC specs are enough high and PC itself is not the case) ! Fixed now with the latest glide you provided

Fixed # III - Alot of lag spikes which again is not due to my PC specs but revision 1.1.1 ! Fixed now with the latest glide you provided

Not Fixed # IV - ingame cursor is not active when i switching back to game while i was alt+tab , i need to double click the D2 Window ( while on windose mode) so cursor to get active again , yes is minor bug but it annoying hopefully u could fix ! Doesnt Happen with revision 1,4 because there is now cursor lock on/off option, ingame cursor still not active in the latest glide you provied

Not Fixed # V - Opening the game with revision 1.1.1 with -ns from a custom loader opens the game with black screen and it stays so! This bug does not exist on revision 1.4 , ** but game still opens black screend while -ns in the latest glide you provied** ! Maybe adding -ns true/false in the d2gl.ini would fix the problem

EDIT: A little Enchancememt here maybe ?
Forcing to start the game Minimezed while -ns ( via loader) in windows mode minimizes the game fine however when i click on the minimized game to start playing the game window becomes black and full screened or the game window appars at the corner of the sreen as and rest of the screen is black !
Mybe issue #V and this are related to each other ?
Video -> https://youtu.be/_hrjw5nn4BY

@bayaraa
Copy link
Owner Author

bayaraa commented Apr 27, 2023

P.S. should the log.txt appear on crash ? Because i do not see any log.txt right now in my d2 folder , yes the game target is with -3dfx -log

d2gl.log will be created when you run game (whether it's crashed or not)

@Ognyan1987
Copy link

P.S. should the log.txt appear on crash ? Because i do not see any log.txt right now in my d2 folder , yes the game target is with -3dfx -log

d2gl.log will be created when you run game (whether it's crashed or not)
saw it !
Passing over a hour now game is still up
d2gl.log

@bayaraa
Copy link
Owner Author

bayaraa commented Apr 27, 2023

@Ognyan1987 thanks.
Is your OS windows 7 or just win7 compatibility mode enabled?

@Ognyan1987
Copy link

Ognyan1987 commented Apr 27, 2023

@Ognyan1987 thanks. Is your OS window 7 or just win7 compatibility mode enabled?

My windows OS is win 10 , i run the game always in compbility mode win xp service pack 3 so i can use mouse 4 and mouse 5 buttons on my mouse , running the game with no comapbility or with win 7 compability loads the game same way but i cannot use Mouse 4 and Mouse 5!
P.S. maybe u can add feture in d2gl players to be able to use M4 and M5 with out a require of setting the game with compability win xp sp 3?

@bayaraa
EDIT: #49 (comment)

@xijin1337
Copy link

@bayaraa
I've been playing non-stop with no problems so far

@bayaraa
Copy link
Owner Author

bayaraa commented Apr 28, 2023

Thanks guys will push new version soon with few additional fixes!

@bayaraa
Copy link
Owner Author

bayaraa commented Apr 29, 2023

pushed new version. thanks for helping.

@bayaraa bayaraa closed this as completed Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants