Skip to content

Conversation

hrfuller
Copy link
Contributor

PR Checklist

Fixes #746
Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
    Tests omitted because we don't have a builtin interpreter which is not of the standalone interpreter variety.
    Unfortunately we can't unit test these bzl files that use the rctx.
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Fixes regression to using custom python_interpreter_target

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@hrfuller hrfuller requested review from f0rmiga and groodt July 12, 2022 20:38
@hrfuller hrfuller requested review from brandjon and lberki as code owners July 12, 2022 20:38
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrfuller hrfuller merged commit df308be into main Jul 12, 2022
@alexeagle alexeagle deleted the hfuller/fix-746 branch May 23, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error calling pip_parse in latest release

2 participants