Skip to content

safely check for standalone interpreter sentinel files #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2022
Merged

safely check for standalone interpreter sentinel files #750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a154eb3
safely check for standalone interpreter sentinel files
Jul 12, 2022
ed90449
Merge branch 'main' into hfuller/fix-746
hrfuller Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/pip_install/pip_repository.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,12 @@ def _maybe_set_xcode_location_cflags(rctx, environment):
Pip won't be able to compile c extensions from sdists with the pre built python distributions from indygreg
otherwise. See https://github.com/indygreg/python-build-standalone/issues/103
"""
python_interpreter_workspace = rctx.path(Label("@{}//:WORKSPACE".format(rctx.attr.python_interpreter_target.workspace_name))).dirname
if (
rctx.os.name.lower().startswith("mac os") and
rctx.attr.python_interpreter_target != None and
rctx.path(Label("@{}//:{}".format(rctx.attr.python_interpreter_target.workspace_name, STANDALONE_INTERPRETER_FILENAME))) and
# This is a rules_python provided toolchain.
rctx.execute(["ls", "{}/{}".format(python_interpreter_workspace, STANDALONE_INTERPRETER_FILENAME)]).return_code == 0 and
not environment.get(CPPFLAGS)
):
xcode_sdk_location = rctx.execute(["xcode-select", "--print-path"])
Expand Down