Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try resolve bazel binary from @bazel/bazelisk installed locally #339

Closed
Toxicable opened this issue Feb 4, 2020 · 3 comments · Fixed by #346
Closed

Try resolve bazel binary from @bazel/bazelisk installed locally #339

Toxicable opened this issue Feb 4, 2020 · 3 comments · Fixed by #346

Comments

@Toxicable
Copy link

Now that @bazel/bazelisk is deployed to npm https://www.npmjs.com/package/@bazel/bazelisk
We should try resolve the bazel binary from that local install.

@achew22
Copy link
Member

achew22 commented Feb 4, 2020

The file in question is here. The way I would go about developing it would be to npm install @bazel/ibazel and @bazel/bazelisk and then manually edit the index.js that is in the ibazel until it exhibits all the functionality you need. Then copy your changed index.js over into this repo and send a PR.

Is there anything else you need from me to get this done?

@alexeagle
Copy link
Collaborator

Last time I made a related change, we did it in the go code:
https://github.com/bazelbuild/bazel-watcher/pull/275/files

I don't remember enough context to say which is better or more correct though

@alan-agius4
Copy link

This is pretty similar to #341 seems like the changes in #275 have regressed.

zoidyzoidzoid added a commit to zoidyzoidzoid/bazel-watcher that referenced this issue Feb 14, 2020
zoidyzoidzoid added a commit to zoidyzoidzoid/bazel-watcher that referenced this issue Feb 14, 2020
zoidyzoidzoid added a commit to zoidyzoidzoid/bazel-watcher that referenced this issue Feb 14, 2020
zoidyzoidzoid added a commit to zoidyzoidzoid/bazel-watcher that referenced this issue Feb 14, 2020
@zoidyzoidzoid zoidyzoidzoid mentioned this issue Feb 14, 2020
1 task
achew22 pushed a commit that referenced this issue Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants