Adds accordions ACT first draft #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micmath
commented
Oct 7, 2020
|
|
||
| ## Rule Description | ||
|
|
||
| The accordion consists of a number of collapsed sections, each with a button to expand that section's content. |
There was a problem hiding this comment.
Must it be a button? (assuming you mean an HTML <BUTTON> ELEMENT)
| ### Expectation 6 | ||
|
|
||
| Each accordion item control has content, preferably text, that describes the content that it controls. | ||
|
|
There was a problem hiding this comment.
Any guidance on cognitive accessibility for control content: Must be conceptually clear and distinct from other control "labels" (are they labels?) for example?
| ### Expectation 8 | ||
|
|
||
| When the accordion item control is activated the value of its `aria-expanded` attribute is toggled between `true` and `false`. | ||
|
|
There was a problem hiding this comment.
It's not clear to me how Expectation 8 is different from Expectation 7.
act/accordions.md
Outdated
|
|
||
| Last modified: 2020-10-04 | ||
|
|
||
| ## Glossary |
There was a problem hiding this comment.
Still wanting to add a "References" section to these. Is that allowed under ACT formatting?
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.