Bugfix/create batch dropdown position final/ab 7511 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadason
approved these changes
Oct 16, 2018
hadason
deleted the
bugfix/create-batch-dropdown-position-final/ab-7511
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://github.com/BDBPayroll/paystream-web/pull/3198
There is an issue in ui-select when in modals and appended to body that casuses flickering and wrong position calculation incalculateDropdownPos().
The solve this, we temporarily detach the ui-select-choices from the flow of the body with position: fixed; (See .ui-select-detached css class) and remove the class when it's time to display to select-choices.
The issue is described here.
You can see the issues clearly in this plunkr.