the pdt_locales/en_AU.py file uses en_A for the localID instead of en_AU

[bear]

A very old mistake that should be fixed - will require a major version bump

found during work on PR #118

[MatthiasKauer]

Why does this require a major version bump? In other words: In what situations should I expect things to break?
I'm trying to figure out if I should modify code in my project that depends on this one.

[bear]

@MatthiasKauer In hindsight I would agree with you - it didn't need a major version bump but I had already rolled it into the v2.0 changes

to be honest the amount of bug fixes that have been made since then is more of a reason to upgrade

[MatthiasKauer]

Thanks for clarifying.
I'll update for sure. I'm mainly trying to figure out where I should look for things to possibly break in my own code with that upgrade.

[bear]

The CHANGES.txt log is very complete, but I realize may not have all of the info you need -- the vast majority of the changes are bug fixes and I don't think we made any changes to how methods are called or their return values.

thanks!

[MatthiasKauer]

I'm coming from that changes file. It is indeed very good. The reason I'm asking is that it lists this issue as sole reason for the major version increase. When I come here, however, it didn't feel so major at first glance. Anyhow, sorry to bother you and thanks for the explanation!

On 25 March 2016 18:46:30 CET, Mike Taylor notifications@github.com wrote:

The CHANGES.txt log is very complete, but I realize may not have all of
the info you need -- the vast majority of the changes are bug fixes and
I don't think we made any changes to how methods are called or their
return values.

thanks!

---

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#120 (comment)

[bear]

glad to help and thanks for the suggestion - I will definitely be more aware of how the changes file reads to others going forward!