ADD: improve russian locale #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@warmonger1 can you check on that failing test that Travis is showing? |
|
Fixed |
| @@ -0,0 +1,27 @@ | |||
| # -*- encoding: utf-8 -*- | |||
There was a problem hiding this comment.
Shouldn't this file be "en_AU.py" to follow naming convention?
There was a problem hiding this comment.
I got name files from self.localeID variable.
I think for pdtLocale_au this variable should be equal en_AU, but compatibility....
There was a problem hiding this comment.
ah - that's a mistake then - the localeID should have been set to en_AU
we will have to fix that and then bump the major version number IMO
|
Hold on... Still some problems. Please check my comment @warmonger1 |
|
@philiptzou sorry - I eager-clicked the merge button! I've fixed the spelling of the en_AU.py file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.