Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsedatetime 2.0 doesn't work on py26 #156

Closed
bmw opened this issue Feb 29, 2016 · 6 comments
Closed

parsedatetime 2.0 doesn't work on py26 #156

bmw opened this issue Feb 29, 2016 · 6 comments
Assignees

Comments

@bmw
Copy link

bmw commented Feb 29, 2016

(venv)[root@489884f36302 tmp.83QxkaCl7I]# pip freeze
parsedatetime==2.0
(venv)[root@489884f36302 tmp.83QxkaCl7I]# python
Python 2.6.6 (r266:84292, Jul 23 2015, 15:22:56) 
[GCC 4.4.7 20120313 (Red Hat 4.4.7-11)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import parsedatetime
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/tmp.83QxkaCl7I/venv/lib/python2.6/site-packages/parsedatetime/__init__.py", line 44, in <module>
    from .pdt_locales import (locales as _locales,
  File "/tmp/tmp.83QxkaCl7I/venv/lib/python2.6/site-packages/parsedatetime/pdt_locales/__init__.py", line 10, in <module>
    from .icu import get_icu
  File "/tmp/tmp.83QxkaCl7I/venv/lib/python2.6/site-packages/parsedatetime/pdt_locales/icu.py", line 88
    result['dateFormats'] = {x: icu_df[x].toPattern() for x in keys}
                                                        ^
SyntaxError: invalid syntax
>>> 
@schoen
Copy link

schoen commented Feb 29, 2016

(dictionary comprehensions don't exist prior to Python 2.7)

@bear bear self-assigned this Feb 29, 2016
@bear
Copy link
Owner

bear commented Mar 1, 2016

@bmw @schoen -- see pr #157

bear added a commit that referenced this issue Mar 1, 2016
unwrap dictionary comprehensions to allow for python 2.6 to work - Issue #156
@bear
Copy link
Owner

bear commented Mar 1, 2016

PR #157 merged - closing issue

@bear bear closed this as completed Mar 1, 2016
@bmw
Copy link
Author

bmw commented Mar 2, 2016

@bear, do you know when a version of parsedatetime containing #157 will be released to PyPI?

@bear
Copy link
Owner

bear commented Mar 2, 2016

@bmw I can do that now... done - v2.1 is on PyPI

@bmw
Copy link
Author

bmw commented Mar 2, 2016

Thanks again for being so unbelievably responsive. I'll update our repo to use v2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants