Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap dictionary comprehensions to allow for python 2.6 to work - Issue #156 #157

Merged
merged 1 commit into from
Mar 1, 2016

Conversation

bear
Copy link
Owner

@bear bear commented Mar 1, 2016

as this is the only place where this type of code was found, I just unwrapped it so python 2.6 was still viable

Review on Reviewable

@codecov-io
Copy link

Current coverage is 77.07%

Merging #157 into master will increase coverage by +0.04% as of 3311ddd

@@            master    #157   diff @@
======================================
  Files           14      14       
  Stmts         1563    1566     +3
  Branches       297     296     -1
  Methods          0       0       
======================================
+ Hit           1204    1207     +3
  Partial         95      95       
  Missed         264     264       

Review entire Coverage Diff as of 3311ddd

Powered by Codecov. Updated on successful CI builds.

@bmw
Copy link

bmw commented Mar 1, 2016

Oh wow! Thanks for being so responsive the last couple days and looking at these issues. Doing both automated and manual tests with Python 2.6, I can't create the issue anymore using this patch.

@bear
Copy link
Owner Author

bear commented Mar 1, 2016

glad it's working for you - i'll merge this in now.

bear added a commit that referenced this pull request Mar 1, 2016
unwrap dictionary comprehensions to allow for python 2.6 to work - Issue #156
@bear bear merged commit c4b3682 into master Mar 1, 2016
@bear bear deleted the issue-156-py26fix branch March 1, 2016 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants