Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsing of link header rels assumed quotes #13

Closed
bear opened this issue Apr 11, 2016 · 1 comment
Closed

parsing of link header rels assumed quotes #13

bear opened this issue Apr 11, 2016 · 1 comment

Comments

@bear
Copy link
Owner

bear commented Apr 11, 2016

The current code is assuming that the rel type portion of the link header was assumed to always have quotes around it but after talking with indiewebcamp folks and reading the RFC, the quotes are only required if the rel-type string itself has a ";" character.

Also tightened up parsing of the link into the url and rel parts by using shlex so it would handle escaping and quotes properly.
bear added a commit that referenced this issue Apr 11, 2016
@bear
update link parsing to fix issue #13
7161c3d
@bear
Copy link
Owner Author

bear commented Apr 11, 2016

fixed in v0.3.6

@bear bear closed this as completed Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bear