fix package name for beautifulsoup4 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
I have no idea why I haven't merged this yet... doh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py contains dependency on
beautifulsoup, which is Beautiful Soup 3 and not compatible with Python 3, breaking pip/setup.py install. Code actually requires Beautiful Soup 4, which is in packagebeautifulsoup4.(I assume everything worked on Python 2, since mf2py pulls in beautifulsoup4 additionally, so that both versions are installed)
EDIT: So Python3 doesn't seem to work anyways out of the box, so this "just" fixes an unnecessary dependency