Skip to content

Commit

Permalink
Remount datasets for "zfs inherit".
Browse files Browse the repository at this point in the history
Changing properties with "zfs inherit" should cause the datasets
to be remounted.  This ensures that the modified property values
will be propagated in to the filesystem namespace where they can
be enforced.  This change is modeled after an identical fix made
to zfs_prop_set().

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#2201
  • Loading branch information
gunnarbeutner authored and behlendorf committed Mar 24, 2014
1 parent 1de1488 commit 4d8c78c
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions lib/libzfs/libzfs_dataset.c
Original file line number Diff line number Diff line change
Expand Up @@ -1655,6 +1655,15 @@ zfs_prop_inherit(zfs_handle_t *zhp, const char *propname, boolean_t received)
* Refresh the statistics so the new property is reflected.
*/
(void) get_stats(zhp);

/*
* Remount the filesystem to propagate the change
* if one of the options handled by the generic
* Linux namespace layer has been modified.
*/
if (zfs_is_namespace_prop(prop) &&
zfs_is_mounted(zhp, NULL))
ret = zfs_mount(zhp, MNTOPT_REMOUNT, 0);
}

error:
Expand Down

0 comments on commit 4d8c78c

Please sign in to comment.