Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert updeep to immer (fixes #704) #755

Merged
merged 6 commits into from
Oct 21, 2022
Merged

Convert updeep to immer (fixes #704) #755

merged 6 commits into from
Oct 21, 2022

Conversation

cxong
Copy link
Contributor

@cxong cxong commented Oct 15, 2022

Changelog

Migrated the data update library from updeep to immer.

@cxong
Copy link
Contributor Author

cxong commented Oct 15, 2022

Screen Shot 2022-10-15 at 4 50 58 pm

I'm unable to test further due to 403 errors

@dtinth
Copy link
Member

dtinth commented Oct 15, 2022

@cxong Hi! Many thanks for contributing.

The 403 error comes from loading a background image and should not affect the game.

To verify that the game works, please run the end-to-end tests, found in the e2e folder.

@cxong
Copy link
Contributor Author

cxong commented Oct 15, 2022

I am getting

Step 1. Open browser NG 3s
        Error: net::ERR_CONNECTION_REFUSED at http://localhost:8080/?server=https://raw.githubusercontent.com/bemusic/bemuse-test-server/master

after running

npx prescript tests/Gameplay-test.js

in e2e

@dtinth
Copy link
Member

dtinth commented Oct 15, 2022

@cxong Hi! Please have the development server running while running the E2E tests.

@cxong
Copy link
Contributor Author

cxong commented Oct 15, 2022

Deferred Step 2. Close browser OK 85ms
すばらしい! 32s

@dtinth
Copy link
Member

dtinth commented Oct 15, 2022

@cxong Great, seems to be working! Almost there — please check the CI status.

  • Some tests are failing. Try running the tests on your local machine.
  • Lint tasks are also failing. Please run rush danger-local to see the warnings.

Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now! Thank you so much for contributing 😄

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dtinth added a commit that referenced this pull request Oct 19, 2022
@dtinth dtinth merged commit 0b0b4e7 into bemusic:master Oct 21, 2022
@cxong cxong deleted the immer branch October 22, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants