(Do not merge)Ben proxy #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heartbeat timeout means the period length that indicates heartbeat is out of service, which is different from heartbeat interval. So we should use '-peer-heartbeat-interval' instead of '-peer-heartbeat-timeout' in etcd. '-peer-heartbeat-timeout' is deprecated but still could be used.
chore: rename 'heartbeat timeout' to 'heartbeat interval'
We have waited too long to document `consistent=true`. Document it!
feat(Documentation): add a section on consistent reads
docs: Add links to haskell bindings and scrz project
Trivial formatting correction
This gets asked about a lot int IRC/mailinglist/etc. Fixes this issue: etcd-io#383 (comment)
feat(Documentation/api): document file upload
The waitIndex was being pulled from the wrong node in the lock parent which caused the watch to be returned immediately. This caused a continuous set of calls while a client was waiting for a lock.
fix(mod/lock): correct watch index to remove cpu load
the drone.io badge is either cached wrong by github or links to a wrong version when we build a branch, just remove it.
…cked Currently this is a workaround. And it should be fixed in Go1.3.
Setting request timeout is covered by go-httpclient now.
fix bugs that are found in issue etcd-io#579
fix trivial issues as I see them
We implement the api client useing php.
Add PHP library.
Added Error 107 to Documentation
docs(CONTRIBUTING): add code style section
…napshot Snapshot can be tens of MB. We need to have a minute level timeout for sending snapshot. We add a separate snapshot http client for snapshot request, which has 120s timeout.
specifically when both prevIndex and prevValue are provided
fix Compare and swap returns incorrect cause
fix(server/transporter.go) fix the short timeout problem of sending snapshot
docs(api) added note for CAS about prevIndex=0 and `cause` meaning in server response
|
@benbjohnson Only the last Please do not merge this one. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.