Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failures due to renamed "fat" target and List.of() unavailable in Java 8 #12

Closed
samlindsaylevine opened this issue Jun 26, 2023 · 0 comments

Comments

@samlindsaylevine
Copy link
Contributor

Steps Taken

As per the readme, run mvn clean install -U (using the Maven version 3.8.1 that is bundled with IntelliJ).

Expected

The build will run and a fat JAR will be created in the /CookieMonster/target directory.

Actual

The build fails; the first failure is a Maven error

Descriptor with ID 'fat' not found

In addition, there is a compile problem because the pom.xml specifies 1.8 as the source and target version, but ChromeBrowser.java uses the factory method List.of() that was added only in Java 9.

Discussion

It appears that the maven-assembly-plugin changed its target from fat to jar-with-dependencies.
The compile problem is remediable by changing the version.

I will soon open a PR to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants