Fix issues #12 and #13, build & ChromeBrowser problems #14
Conversation
…ons of Chrome. Updated Maven "fat" target to "jar-with-dependencies". Updated Maven source/target JDK version to 1.9. Updated ChromeBrowser to look for files ending in "Cookies" in any subdirectory, to handle modern Windows Chrome that puts it in Default/Network. Updated ChromeBrowser to skip un-decryptable cookies in Windows, rather than fail with an exception, to match Mac and Linux behavior.
| @@ -291,7 +294,7 @@ protected DecryptedCookie decrypt(EncryptedCookie encryptedCookie) { | |||
| decryptedBytes = cipher.doFinal(ciphertextTag); | |||
| } | |||
| catch (Exception e) { | |||
| throw new IllegalStateException("Error decrypting", e); | |||
| decryptedBytes = null; | |||
There was a problem hiding this comment.
This matches the exception-handling behavior for Linux & Mac (the cookie is skipped).
|
I wanted to thank you again, Ben, for your continued work in this repository; I appreciate this functionality being available to a few of my personal projects. |
|
I just cloned the project and issues 12, 13 still apear in the code, Do I need some other branch, then master? |
This pull request was just opened yesterday and has not been merged. It is a pull request from the If you would like to, you are more than welcome to clone my fork, check out the appropriate branch, and verify that the issues have been resolved by my changes. |
|
Thanks! Sorry for being slow on the merge... |
|
No need to apologize and thank you again! |
Fixes to build process and to ChromeBrowser for current Windows versions of Chrome.
Updated Maven "fat" target to "jar-with-dependencies". Updated Maven source/target JDK version to 1.9.
Updated ChromeBrowser to look for files ending in "Cookies" in any subdirectory, to handle modern Windows Chrome that puts it in Default/Network. Updated ChromeBrowser to skip un-decryptable cookies in Windows, rather than fail with an exception, to match Mac and Linux behavior.
This PR addresses and should resolve issue #12 and issue #13 .
I have successfully rebuilt the fat JAR and updated the file that is checked into the root of the repository with the output from
/CookieMonster/target/CookieMonster-jar-with-dependencies.jar, and also verified thatnew ChromeBrowser().getCookies()returns the expected, non-empty result with my latest version of Chrome on Windows.