Fixed error if API version not received. #203
Conversation
|
@hydra: I found a simple way to fix the infinite loop issue - now the behaviour is that if there are no pages with a suitable version found, the script cycles through all of the unsuitable pages as if there was no check. I don't think there is a way for the script to self-terminate - the ui routine will just be called over and over again. |
|
Still looking at this... since Will keep digging.. |
src/SCRIPTS/BF/ui.lua
Outdated
| while Page == nil do | ||
| Page = assert(loadScript(radio.templateHome .. PageFiles[currentPage]))() | ||
| if Page.requiredVersion and Page.requiredVersion > apiVersion then | ||
| if Page.requiredVersion and apiVersion and Page.requiredVersion > apiVersion and currentPage ~= nextPage then |
There was a problem hiding this comment.
apiVersion will always evaluate to true if it is not nil.
> x = 0
> if x then print(1) end
1
Given that apiVersion is initialized as 0 and is never nil, the boolean check for this variable will always be true
Perhaps nesting currentPage ~= nextPage within this if statement would permit a way to gracefully exit when they are equivalent.
There was a problem hiding this comment.
I have added exiting if no valid pages are found.
|
Anybody in for a review? |
|
didnt work on X9D, apiversion still not received. Within data initialized in ui works. |
No description provided.