Updated build script to fail upon compilation error and report status of all files #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
requested changes
Nov 17, 2017
bin/build.sh
Outdated
| if [[ $FAIL -eq 0 ]]; then | ||
| echo -e "\e[1m\e[39m[\e[32mTEST SUCCESSFUL\e[39m]\e[21m All lua files built successfully!" | ||
| fi | ||
| exit $FAIL |
There was a problem hiding this comment.
Exiting with a status that is a logical or of all exit codes is a bit awkward, and makes it impossible to do something meaningful with the exit status. We should probably rather exit with the last failed compilation exit status.
codecae
force-pushed
the
build_script_parse_fix
branch
4 times, most recently
from
6e4e45a to
467ac1f
Compare
codecae
force-pushed
the
build_script_parse_fix
branch
from
467ac1f to
d74fa4c
Compare
|
These changes looking any better? |
mikeller
approved these changes
Nov 20, 2017
|
@codecae: Much better. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current script will report build failures but exits 0 in CI when failures exist. This update will provide all file compilation statuses and exit on failure if one of them has a build issue.