-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADAM-1170] Deprecate SAMFileHeaderWritable #2156
Conversation
Test PASSed. |
Some local benchmarksRan bam/sam conversions to adam format via adam-submit. 800MB bam fileOLD:
NEW:
3.6GB SAM fileOLD
NEW
|
What, did that last run terminate early or something? |
Fixed |
Thanks, that looks better. I only expect to see differences (if any) across multi-node clusters, because this pull request changes how the headers are serialized. Unfortunately, this #2157 prevents running on 2.2.x on the bdg cluster, and we don't have Spark 2.4.x available there yet. |
Here are some results running on (rather undersized) m3.xlarge instances in AWS EMR for 5.7G BAM file on HDFS git HEAD
#2156 heuermh:prepare-for-convert branch
|
003aa6c
to
b58e2c7
Compare
Test PASSed. |
Fixes #1170