Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AR Add: Skip Analyses in disabled categories #2319

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

Linked issue: #2317

Current behavior before PR

AR Add form fails if an Analysis Category was disabled

Desired behavior after PR is merged

AR Add does not show services in disabled Analysis Categories

--
I confirm I have tested this PR thoroughly and coded it according to PEP8 standards.

@ramonski ramonski merged commit 358201b into master Nov 21, 2017
@ramonski ramonski deleted the bugfix/issue-2317-ar-add-fails-if-analysis-category-was-disabled branch November 21, 2017 10:36
ramonski pushed a commit that referenced this pull request Nov 21, 2017
* Fixed bug when finding correct ID number after ng_flush

* Normalize out unicode chars and change IDServer test to check

* Initialise ID server separator from kwargs

* Pass error messages to the frontend (#2318)

* Skip Analyses in disabled categories (#2319)

* Fixed bug when finding correct ID number after ng_flush

* Normalize out unicode chars and change IDServer test to check

* Initialise ID server separator from kwargs

* PEP8

* Get sequence number from ID

* Added function to generate the storage key

* removed unused function

* Better Number Generator Management View

* Added ng_flush to IDServer test

* Added ng_flush to IDServer test

* Fixed ID Preview

* Removed comment from test

* get Number Generator Utility explicitly

* Better ID Sequence Deconstruction

* remove storage key if value is 0
xispa referenced this pull request in xispa/senaite.core Nov 22, 2017
xispa referenced this pull request in xispa/senaite.core Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant