Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Is it possible to commit version change on git, using a simple flag? #66

Closed
Sebastian-G opened this issue Aug 10, 2021 · 1 comment

Comments

@Sebastian-G
Copy link

Sebastian-G commented Aug 10, 2021

Is it possible to commit version change on git, using a simple flag?

Is there any best practice about dealing with the changes if the deploy command is running in a CI/CD pipeline?

https://docs.npmjs.com/cli/v7/commands/npm-version

NPM version is automatically committing the change after patching the version, I would love to use this feature on the deploy command.

Is this feature already contained? And it is only mandatory to git push --tags?

@dianjuar
Copy link
Member

dianjuar commented Sep 7, 2021

Hi @Sebastian-G.
I'm glad that you brought that subject to the table.

I can understand that the version managing of a package could be a difficult task and for that reason, we decide to exclude it from the responsibilities of this builder/plugin. We explain it on the documentation.

Something that you can do tough, is you manage the strategy of versioning that you prefer (that better suits you) and use the option --package-version to publish the version that your strategy wants.


It really depends on my opinion of convention, culture, QA and, infrastructure to achieve true automation.

If you are looking for a tool I think your best bet is semver.


I have a slide to explain how we are going to manage that aspect to my coworkers, it might inspire you -> quality-on-project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants