Rebase to origin #1

billy34 · 2020-01-29T08:23:17Z

Please ensure the following before submitting a PR:

if suggesting code changes or improvements, open an issue first
for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
add code or new test files to /tests for any new functionality or bug fix
make sure R CMD check runs without error before submitting the PR

…nd for #33

Currently fq is completely broken: 1. It requires start to be set for no reason 2. It fails because match.arg will always fail since no args are given in the function This fix does three things: 1. Test for fq rather than start 2. get rid of the match.arg -- since fq is super flexible, we can't use that here 3. enclose the fq query in I to prevent URL encoding (see r-lib/httr#540 (comment) ). Otherwise, httr encodes colons, square brackets and + and e.g. the [example for date range search](http://guides.dataverse.org/en/latest/api/search.html#date-range-search-example) breaks

ref #38

from 6.1.1 ref #38

@leeper

@leeper, I believe thesee are the correct modifications, according to [CRAN](https://journal.r-project.org/archive/2012/RJ-2012-009/RJ-2012-009.pdf) and [Hadley](http://r-pkgs.had.co.nz/description.html). Tell me if you think I've misinterpreted something. @pdurbin, please check your ORCID number. I found it [here](https://dataverse.harvard.edu/dataset.xhtml?persistentId=doi:10.7910/DVN/TJCLKP) ref #38

also, remove date ref #38

addressing 404 errors in vignette

@kuriwaki

cc: @kuriwaki ref #33

also correct `create_dataverse()` ref #33

run in a new environment ref #33

ref #4

ref #40

This interferes with all the assignments that happens within the function parameter defaults. And also the tests. ref #40

https://demo.dataverse.org/dataverse/dataverse-client-r ref #40

ref #38

ref #44

ref #40

https://style.tidyverse.org/tests.html#organisation-1 ref #4

@leeper

from @leeper ref #38

Dev

Fix handling of fq

fix multi-download for datasets with folders and change logic

Add ability to download zip of multiple files

and update NEWS as per #50

Add myself as author

Add kuriwaki as author

kuriwaki and others added 30 commits December 11, 2019 11:51

remove query option for format != "bundle" & length == 1, as workarou…

27560a2

…nd for #33

apply styler

dec7e34

standardize to read_dta if doing #34

2343c4a

roxygen 7.0.2

ed5b4fd

backtrack; use query if the target looks like a .tab file for #33

4d45330

easier to read file headers

0f00b66

distinguish fileid and filename to make 4d45330 work

5ec375b

workaround for #32

49fd9e5

add test for fq date range search

409fd5b

Rproj file

2e61c4d

ref #38

update Roxygen to 7.0.2

3f4b680

from 6.1.1 ref #38

bump version number to indicate dev

adb763f

also, remove date ref #38

Merge pull request #39 from kuriwaki/master

997d300

addressing 404 errors in vignette

catch case if file is already specified as a number

add1b62

cc: @kuriwaki ref #33

Clearly state dvn isn't on CRAN any more

e8a9126

also correct `create_dataverse()` ref #33

more sympathetic if archived scripts don't run automatically

d69422d

run in a new environment ref #33

verify travis fails bad test

8db3a35

ref #4

test should fail-but doesn't

cd499aa

ref #40

read Dataverse token from yaml --test should fail!

5104783

ref #40

remove intentionally failing test

468e77e

ref #40

Don't load server name by default

436f788

This interferes with all the assignments that happens within the function parameter defaults. And also the tests. ref #40

switch to example dataset

9df8c6c

https://demo.dataverse.org/dataverse/dataverse-client-r ref #40

numeric file id (already done in add1b62)

5a21467

Add list of freqeuntly-used developer tasks

b95d33a

ref #38

remove trailing whitespace

b7a511c

ref #44

move package assertion & warning closer together

551d11c

ref #40

alphabetize package dependencies

7e598a7

checkmate package required for testing

664caf2

ref #40

wibeasley and others added 18 commits January 3, 2020 09:49

create manifest and testing helpers

63d1ce2

ref #40

dedicate a test file to a single function

041f42f

https://style.tidyverse.org/tests.html#organisation-1 ref #4

point to IQSS/dataverse-client-r

8db7abf

from @leeper ref #38

Merge pull request #43 from IQSS/dev

fb38f14

Dev

Fix test ad no result test

c39f770

More fq tests

03fb515

Merge pull request #36 from adam3smith/patch-1

012058e

Fix handling of fq

Add ability to download zip of multiple files

d38ed88

revert zip of multiples

21bb003

fix multi-download for datasets with folders and change logic

Fix test

eb7b90d

Merge pull request #47 from adam3smith/zip-downloads

8b425ab

Add ability to download zip of multiple files

Add myself as author

4497782

and update NEWS as per #50

numeric file id (already done in add1b62)

044c91e

Merge branch 'master' of https://github.com/kuriwaki/dataverse-client-r

8393c7b

add as author and summarize changes

a9757ae

Merge pull request #52 from adam3smith/credits

5d7ddea

Add myself as author

Merge branch 'master' into master

3c6e447

Merge pull request #53 from kuriwaki/master

0b3d67c

Add kuriwaki as author

billy34 merged commit 557e9ee into billy34:master Jan 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase to origin #1

Rebase to origin #1

billy34 commented Jan 29, 2020

Rebase to origin #1

Rebase to origin #1

Conversation

billy34 commented Jan 29, 2020