Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Conversation

khalidibrahimio
Copy link
Contributor

Q                       A
Fixed Issues?
Patch: Bug Fix? Kinda (backend's bug)
Major: Breaking Change? No
Minor: New Feature? Yes
Tests Added + Pass? Yes
Does not reduce coverage? Yes
Any Dependency Changes?

Refreshes every contract in the trade table 3 seconds after it's sold

ashkanx and others added 30 commits January 11, 2019 08:10
@coveralls
Copy link

coveralls commented Apr 29, 2019

Coverage Status

Coverage increased (+0.1%) to 72.337% when pulling 65cedfb on Khalidxx:refresh-contracts into 050a040 on binary-com:dev.

export const bottomWarningLink = { textDecoration: 'underline' };

export const green = { color: 'green' };
export const green = { color: 'green', float: 'left' };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding this float the totalWins and totalLosses cells in the account overview at the bottom of the table are incorrectly aligned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll make separate style variables for each

@@ -1,3 +1,4 @@
/* eslint-disable no-debugger */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this eslint exception.

@ashkanx ashkanx merged commit bf06c93 into binary-com:dev May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants