Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

Conversation

qingweibinary
Copy link
Contributor

…ebug

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 35.363% when pulling ce2f207 on qingweibinary:qingwei/add_test into e84dcb4 on binary-com:master.

ticks: fromJS({ R_9000: [{ quote: 123 }] }),
trades: fromJS([{ symbol: 'R_9000' }]),
tradingOptions: fromJS([]),
tradingOptions: new Map({ R_9000: contractsForR_50 }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fromJS({}) will create a map anyways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but we have more problem on that XD
TradingOptions need some work, now it's a immutable object containing mutable js object, so using fromJS will convert everything to immutable and breaks.

I did not make big change to solve it altogether yet as some selectors depends on the mutable version

@borisyankov borisyankov merged commit a113314 into regentmarkets-repo-archive:master Mar 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants