Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

Conversation

DanSallau
Copy link
Contributor

Get residence list from server instead.

api.events.on(key, () => window.console.warn);
});

api.getResidences();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the place man ~~
See where we place such calls, in the same file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qingweibinary that call either belong there , or veryfEmailCard to my understanding. "See where we place such calls" like ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we've removed the initUnAuth, my bad

I think we should call when needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuruddeensalihu I agree with @qingweibinary
Please do the changes before me merging this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@borisyankov where do we need to change ? I think if you agree with qingwei then you agree with me by extension. 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should call when needed ;)

@borisyankov
Copy link
Contributor

Also fix merge conflict ;)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 31.732% when pulling 3638994 on nuruddeensalihu:nuru/fix_countryList into c8ee51a on binary-com:master.

@borisyankov borisyankov merged commit bb7ecbd into regentmarkets-repo-archive:master Aug 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants