Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

Conversation

qingweibinary
Copy link
Contributor

No description provided.

@qingweibinary
Copy link
Contributor Author

Super high level view

screen shot 2016-07-28 at 3 16 52 pm

@qingweibinary
Copy link
Contributor Author

TODO

  1. Add subscription call for all params change saga
  2. Properly disable purchase button, might need to shift debounce into Saga, using delay
  3. Make sure we always sync params change from UI into redux store, although UI does not always reflect from redux store

return (
<div className="param-row forward-starting-picker">
{allowStartLater && <Label text={'Start Time'} />}
{<Label text="Start Time" />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the {} now ;)

@qingweibinary
Copy link
Contributor Author

Yes ~

@coveralls
Copy link

Coverage Status

Coverage increased (+2.1%) to 30.731% when pulling a8ea57b on qingweibinary:qingwei/refactor_to_saga into 4f8f6c1 on binary-com:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 30.766% when pulling b0db1a9 on qingweibinary:qingwei/refactor_to_saga into 4f8f6c1 on binary-com:master.

@qingweibinary qingweibinary force-pushed the qingwei/refactor_to_saga branch from b0db1a9 to 70190a5 Compare August 2, 2016 05:02
@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 30.766% when pulling 70190a5 on qingweibinary:qingwei/refactor_to_saga into 4f8f6c1 on binary-com:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 28.779% when pulling af19c5e on qingweibinary:qingwei/refactor_to_saga into 830a7b1 on binary-com:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 31.063% when pulling 457bd74 on qingweibinary:qingwei/refactor_to_saga into 830a7b1 on binary-com:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.0%) to 31.585% when pulling b6abae8 on qingweibinary:qingwei/refactor_to_saga into 830a7b1 on binary-com:master.

@borisyankov borisyankov merged commit a7ae437 into regentmarkets-repo-archive:master Aug 2, 2016
@qingweibinary qingweibinary deleted the qingwei/refactor_to_saga branch August 15, 2016 01:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants