This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Fix start later time issue in FF and safari #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 71276fd on nuruddeensalihu:nuru/fix_start_later_time into * on binary-com:master*. |
| onTimeChange = e => { | ||
| const { dateStart } = this.props; | ||
| const inputValue = e.target.value; | ||
| const inputValue = e.target.value.split(':') |
There was a problem hiding this comment.
This looks to me like something worthy of separate function + unit tests.
There was a problem hiding this comment.
ok, but we are not using it anywhere and not likely to. Its not complex or complicated also. That's why i didn't think of the necessity.
|
@borisyankov have moved the validation to binary-utils here regentmarkets-repo-archive/binary-utils#29 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Attached contain little changes that should address the card here for your perusal.
https://trello.com/c/jLKYQwhV/765-firefox-and-safari-parameters-of-the-trading-will-be-reset-if-user-modify-the-start-time