Ameerul /P2PS-1562 Migrate server-ts.js fiile to typescript #10107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameerul-deriv
requested review from
farrah-deriv and
nijil-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-1562-migrate-server-time.binary.sx/ |
…62-migrate-server-time
farrah-deriv
requested changes
Sep 18, 2023
removed remaining_time observable Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com>
…riv/deriv-app into P2PS-1562-migrate-server-time
|
Kudos, SonarCloud Quality Gate passed!
|
niloofar-deriv
approved these changes
Sep 19, 2023
farrah-deriv
previously approved these changes
Sep 21, 2023
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
commenting to remove stale |
ameerul-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
ameerul-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
…62-migrate-server-time
ameerul-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
ameerul-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
|
Kudos, SonarCloud Quality Gate passed!
|
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
lubega-deriv
pushed a commit
to lubega-deriv/deriv-app
that referenced
this pull request
Dec 26, 2023
…m#10107) * chore: combined server-time with server_time file * chore: added test cases for server_time * chore: updated test case * chore: removed unused setRemainingTime * Apply suggestions from code review removed remaining_time observable Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> * chore: changed typing of error to Error --------- Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Signed-off-by: lubega-deriv <lubega@deriv.com>
lubega-deriv
pushed a commit
to lubega-deriv/deriv-app
that referenced
this pull request
Dec 26, 2023
…m#10107) * chore: combined server-time with server_time file * chore: added test cases for server_time * chore: updated test case * chore: removed unused setRemainingTime * Apply suggestions from code review removed remaining_time observable Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> * chore: changed typing of error to Error --------- Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Signed-off-by: lubega-deriv <lubega@deriv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.