Rupato/BOT-686/fix: added test case for filters #10586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupato-deriv
requested review from
prince-deriv and
sandeep-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rupato-deriv
changed the title
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-bot-686testcases-132fd3.binary.sx/ |
farabi-deriv
approved these changes
Oct 12, 2023
Comment on lines
+25
to
+38
| it('should render filter component', () => { | ||
| render( | ||
| <Filters | ||
| wrapper_ref={createMockRef} | ||
| checked_filters={journal_filters} | ||
| filters={journal_filters} | ||
| filterMessage={mockFilterMessage} | ||
| className='sample-classname' | ||
| classNameLabel='sample-classname-label' | ||
| id='test' | ||
| /> | ||
| ); | ||
| const el = screen.getByText('Errors'); | ||
| userEvent.click(el); |
There was a problem hiding this comment.
@rupato-deriv Is this case completed?
|
Kudos, SonarCloud Quality Gate passed!
|
shafin-deriv
approved these changes
Oct 19, 2023
sandeep-deriv
approved these changes
Oct 23, 2023
aum-deriv
pushed a commit
to aum-deriv/deriv-app
that referenced
this pull request
Oct 23, 2023
* fix: added test case for filters * fix: added expect to check active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added test case for filter component inside dashboard