Skip to content

Conversation

@hamza-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.
New config file to remove the hard-coded variables from the cfd package, and to start using the single source of truth.

Screenshots:

Please provide some screenshots of the change.
image

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 16, 2023 10:06am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10712](https://github.com/binary-com/deriv-app/pull/10712)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-new-cfd-config-file.binary.sx?qa_server=red.binaryws.com&app_id=36517
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-new-cfd-config-file.binary.sx
- **App ID**: `36517`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-new-cfd-config-file.binary.sx/

@matin-deriv matin-deriv merged commit 75e4b28 into deriv-com:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants