Skip to content

Conversation

farabi-deriv
Copy link
Contributor

Changes:

  • Added test case for route-prompt-dialog
  • Added setShouldShow on route-prompt-dialog-store

Screenshots:

Screenshot 2023-10-25 at 7 36 23 PM

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 26, 2023 9:16am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10959](https://github.com/binary-com/deriv-app/pull/10959)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-758test-case-c095ea.binary.sx?qa_server=red.derivws.com&app_id=24046
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-758test-case-c095ea.binary.sx
- **App ID**: `24046`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-758test-case-c095ea.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 26.939% (+0.02%) from 26.923% when pulling 1757233 on farabi-deriv:farabi/bot-758/test-case-for-route-prompt-dialog into f6f566f on binary-com:master.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

@sandeep-deriv sandeep-deriv merged commit 009274a into deriv-com:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants