[DTRA] Maryia/DTRA-450/feat: use CF Stream as a source for DTrader videos #11030

maryia-deriv · 2023-10-29T23:50:36Z

Changes:

use Cloudflare Stream as a source for description videos for Accumulators and Vanillas instead of video files in the code base. Keep picture-in-picture disabled;
update Accumulators video;
add the new Turbos video;
add comments with examples and instructions for the future creation of a custom player.

Screenshots:

Test coverage of the newly added VideoStream component:

vercel · 2023-10-29T23:50:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Nov 27, 2023 0:32am

github-actions · 2023-10-30T00:03:09Z

A production App ID was automatically generated for this PR. (log)

PR: [DTRA] Maryia/DTRA-450/feat: use CF Stream as a source for DTrader videos #11030
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-maryia-deriv-maryia-dtra-450cf-stream-video.binary.sx?qa_server=red.derivws.com&app_id=32508
- Original: https://deriv-app-git-fork-maryia-deriv-maryia-dtra-450cf-stream-video.binary.sx
App ID: 32508

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/11030](https://github.com/binary-com/deriv-app/pull/11030)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-deriv-maryia-dtra-450cf-stream-video.binary.sx?qa_server=red.derivws.com&app_id=32508
    - **Original**: https://deriv-app-git-fork-maryia-deriv-maryia-dtra-450cf-stream-video.binary.sx
- **App ID**: `32508`

github-actions · 2023-10-30T00:04:05Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	16
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟧 PWA	80

Lighthouse ran with https://deriv-app-git-fork-maryia-deriv-maryia-dtra-450cf-stream-video.binary.sx/

…RA-450/cf-stream-video

…DTRA-450/cf-stream-video

coveralls · 2023-11-08T08:33:03Z

coverage: 28.982% (+0.03%) from 28.951%
when pulling 085aef5 on maryia-deriv:maryia/DTRA-450/cf-stream-video
into 714d4d6 on binary-com:master.

…RA-450/cf-stream-video

gitguardian · 2023-11-10T09:10:51Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`b48aeb8`	nx.json	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

…DTRA-450/cf-stream-video

github-actions · 2023-11-27T08:59:29Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-27T08:59:37Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-27T08:59:38Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-27T08:59:45Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-27T09:15:48Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-27T09:15:59Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-27T09:17:07Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

…DTRA-450/cf-stream-video

github-actions · 2023-11-27T12:16:19Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-27T12:16:37Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-27T12:16:38Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-27T12:16:41Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-27T12:16:41Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-27T12:16:43Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

sonarqubecloud · 2023-11-27T12:24:52Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

github-actions · 2023-11-27T12:32:47Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-27T12:32:53Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-27T12:33:36Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-11-27T12:33:37Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-11-27T12:33:39Z

⏳ Generating Lighthouse report...

github-actions · 2023-11-27T12:33:55Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

feat: use Stream component to render video from cloudflare stream

c1da371

maryia-deriv requested review from balakrishna-deriv, matin-deriv and yashim-deriv as code owners October 29, 2023 23:50

boring-cyborg bot added the Trader label Oct 29, 2023

vercel bot deployed to Preview October 30, 2023 00:02 View deployment

refactor: introduced a variable for an accumulator video unique id

efe827a

vercel bot deployed to Preview October 30, 2023 00:21 View deployment

refactor: + remove unused video files

46aacb0

maryia-deriv requested a review from ali-hosseini-deriv as a code owner October 30, 2023 00:58

boring-cyborg bot added the Core label Oct 30, 2023

vercel bot deployed to Preview October 30, 2023 01:10 View deployment

maryia-deriv added 2 commits October 30, 2023 15:27

Merge branch master of github.com:binary-com/deriv-app into maryia/DT…

53d7055

…RA-450/cf-stream-video

Merge branch 'master' of github.com:binary-com/deriv-app into maryia/…

5501ff3

…DTRA-450/cf-stream-video

maryia-deriv deployed to Preview October 30, 2023 12:29 — with GitHub Actions View deployment

maryia-deriv changed the title ~~Maryia/DTRA-450/feat: use Cloudflare Stream as a source for description videos~~ [DTRA] Maryia/DTRA-450/feat: use Cloudflare Stream as a source for description videos Nov 8, 2023

maryia-deriv added 2 commits November 10, 2023 10:10

Merge branch master of github.com:binary-com/deriv-app into maryia/DT…

b48aeb8

…RA-450/cf-stream-video

build: update lock file

1e004fb

maryia-deriv requested review from adrienne-deriv, farhan-nurzi-deriv and thisyahlen-deriv as code owners November 10, 2023 09:10

maryia-deriv requested a review from a user November 10, 2023 09:10

maryia-deriv had a problem deploying to Preview November 10, 2023 09:10 — with GitHub Actions Failure

maryia-deriv deployed to Preview November 10, 2023 09:11 — with GitHub Actions View deployment

Merge branch 'master' of github.com:binary-com/deriv-app into maryia/…

c20fb21

…DTRA-450/cf-stream-video

maryia-deriv deployed to Preview November 27, 2023 08:59 — with GitHub Actions View deployment

henry-deriv approved these changes Nov 27, 2023

View reviewed changes

balakrishna-deriv approved these changes Nov 27, 2023

View reviewed changes

kate-deriv approved these changes Nov 27, 2023

View reviewed changes

Merge branch 'master' of github.com:binary-com/deriv-app into maryia/…

085aef5

…DTRA-450/cf-stream-video

maryia-deriv temporarily deployed to Preview November 27, 2023 12:16 — with GitHub Actions Inactive

maryia-deriv deployed to Preview November 27, 2023 12:16 — with GitHub Actions View deployment

balakrishna-deriv merged commit a3761ff into deriv-com:master Dec 1, 2023

[DTRA] Maryia/DTRA-450/feat: use CF Stream as a source for DTrader videos #11030

[DTRA] Maryia/DTRA-450/feat: use CF Stream as a source for DTrader videos #11030

Uh oh!

Conversation

maryia-deriv commented Oct 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Screenshots:

Uh oh!

vercel bot commented Oct 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitguardian bot commented Nov 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

sonarqubecloud bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

github-actions bot commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

maryia-deriv commented Oct 29, 2023 •

edited

Loading

vercel bot commented Oct 29, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023 •

edited

Loading

coveralls commented Nov 8, 2023 •

edited

Loading

gitguardian bot commented Nov 10, 2023 •

edited

Loading

github-actions bot commented Nov 27, 2023 •

edited

Loading