Skip to content

Conversation

markodonnell-deriv
Copy link
Contributor

@markodonnell-deriv markodonnell-deriv commented Oct 31, 2023

Create yml that will run e2e smoke tests after PR comment has been edited (e.g. by Vercel update). This yml is based on the smoketest.yml that is already up and running in Deriv-com, with which @balakrishna-deriv has had some visibility.

The current test that this will run is a very simple. i.e. Login and test app-trader account switcher. We will add to the tests gradually so as to bed the process in gently.

NB. I have run this past @ali-hosseini-deriv and see https://app.clickup.com/t/20696747/FEQ-873, if other approvers require further info. And I have added the requisite E2E_ secrets as defined in the Cypress env variable section.

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Create yml that will run e2e smoke tests after PR comment has been edited (e.g. by Vercel update).

The current tests is a simple initial test. i.e. Login and test app-trader account switcher.
@vercel
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 1, 2023 9:53am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11070](https://github.com/binary-com/deriv-app/pull/11070)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-markodonnell-deriv-create-e2etest-yml.binary.sx?qa_server=red.derivws.com&app_id=32925
    - **Original**: https://deriv-app-git-markodonnell-deriv-create-e2etest-yml.binary.sx
- **App ID**: `32925`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-markodonnell-deriv-create-e2etest-yml.binary.sx/

@coveralls
Copy link

coveralls commented Oct 31, 2023

Coverage Status

coverage: 27.176%. remained the same when pulling cee57bd on markodonnell-deriv-create-e2etest-yml into a00ea21 on master.

@ali-hosseini-deriv
Copy link
Contributor

on question that I have is that on each comment edit action it's gonna run?
is it possible to prevent unwanted runs?

@balakrishna-deriv
Copy link
Contributor

@ali-hosseini-deriv vercel_preview_url action prevents the unwanted runs.

@markodonnell-deriv
Copy link
Contributor Author

on question that I have is that on each comment edit action it's gonna run? is it possible to prevent unwanted runs?

Good question. I was just following the lighthouse yml model. If there's a better way of tiggering the run only after the Vercel site is ready, both processes would benefit.

Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@markodonnell-deriv markodonnell-deriv requested review from yashim-deriv and removed request for yashim-deriv November 1, 2023 09:45
@markodonnell-deriv markodonnell-deriv merged commit 7bd0575 into master Nov 1, 2023
@ali-hosseini-deriv ali-hosseini-deriv deleted the markodonnell-deriv-create-e2etest-yml branch August 16, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants