[Wallet] george / Fix UI inconsistencies in CashierWalletHeader component #11145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heorhi-deriv
requested review from
adrienne-deriv,
farhan-nurzi-deriv and
thisyahlen-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-86bwavj4q-fix-cashier-he-636109.binary.sx/ |
yashim-deriv
previously approved these changes
Nov 3, 2023
farhan-nurzi-deriv
previously approved these changes
Nov 3, 2023
nijil-deriv
reviewed
Nov 3, 2023
heorhi-deriv
dismissed stale reviews from matin-deriv, farhan-nurzi-deriv, and yashim-deriv
via
3fd9c2c
|
Kudos, SonarCloud Quality Gate passed!
|
farhan-nurzi-deriv
approved these changes
Nov 3, 2023
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
|
🚀 Smoke test run (1) passed successfully! |
|
🚀 Smoke test run (2) passed successfully! |
nijil-deriv
approved these changes
Nov 3, 2023
aum-deriv
pushed a commit
to aum-deriv/deriv-app
that referenced
this pull request
Nov 6, 2023
…nent (deriv-com#11145) * style: 💄 fix icon xl size, jurisdiction badge, text xl line-height size * style: 💄 add gap in mobile view * style: 🎨 replace svg fiat currency icons with proper ones
aum-deriv
pushed a commit
to aum-deriv/deriv-app
that referenced
this pull request
Nov 6, 2023
…nent (deriv-com#11145) * style: 💄 fix icon xl size, jurisdiction badge, text xl line-height size * style: 💄 add gap in mobile view * style: 🎨 replace svg fiat currency icons with proper ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
line-heightforWalletTextcomponentxlsize from 34px to 36pxroundedcurrency icon sizexlfrom 56px to 64pxWalletListCardBadge(Jurisdiction Badge), add fixed height, replace border to outlineCashierWalletHeadercomponentScreenshots: