Skip to content

Conversation

@thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Update to use WalletPasswordField to the create and enter password modal

Screenshots:

Please provide some screenshots of the change.
Screenshot 2023-11-09 at 10 19 49 AM

@vercel
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 9, 2023 4:01am

@coveralls
Copy link

coveralls commented Nov 9, 2023

Coverage Status

coverage: 26.611% (+0.02%) from 26.589%
when pulling 9be462f on thisyahlen-deriv:thisyahlen/WALL-2489/integrate_WalletPasswordField_in_create_password
into f2615da on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11291](https://github.com/binary-com/deriv-app/pull/11291)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-2489-c344e8.binary.sx?qa_server=red.derivws.com&app_id=23809
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-2489-c344e8.binary.sx
- **App ID**: `23809`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-2489-c344e8.binary.sx/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

🚀 Smoke test run (1) passed successfully!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

🚀 Smoke test run (2) passed successfully!

@chrisgodfrey-deriv
Copy link

Please use the [WALL] prefix for the PR title.

The text needs removing from the description as this is just placeholder text:
"Screenshots:
Please provide some screenshots of the change."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants