Skip to content

Conversation

maryia-deriv
Copy link
Contributor

Changes:

  • to fix Vanilla Duration disappearing when switching from a Duration that is unavailable for Vanillas (e.g. Ticks/Minutes) on another trade type (e.g. Rise/Fall).

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 10, 2023 11:27am

@maryia-deriv maryia-deriv changed the title [DTRA] Maryia/WEBREL-1645/fix: Vanilla Duration disappears when switching from unavailable Duration on another trade type [DTRA] Maryia/WEBREL-1645/Hotfix: Vanilla Duration disappears when switching from unavailable duration Nov 10, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.7% 8.7% Duplication

@coveralls
Copy link

coveralls commented Nov 10, 2023

Coverage Status

coverage: 27.297% (+0.005%) from 27.292%
when pulling fe1f1df on maryia-deriv:maryia/WEBREL-1645/vanilla-duration-fix
into 6fd2333 on binary-com:master.

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11345](https://github.com/binary-com/deriv-app/pull/11345)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-deriv-maryia-webrel-1645vanill-dd9f64.binary.sx?qa_server=red.derivws.com&app_id=23835
    - **Original**: https://deriv-app-git-fork-maryia-deriv-maryia-webrel-1645vanill-dd9f64.binary.sx
- **App ID**: `23835`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-maryia-deriv-maryia-webrel-1645vanill-dd9f64.binary.sx/

Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@maryia-deriv maryia-deriv merged commit 85202bd into deriv-com:master Nov 10, 2023
maryia-deriv added a commit that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants