Skip to content

[COJ]/likhith/[213]-fix: POA layout for MT5 #11502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2023
Merged

[COJ]/likhith/[213]-fix: POA layout for MT5 #11502

merged 3 commits into from
Nov 21, 2023

Conversation

@likhith-deriv
Copy link
Contributor

@likhith-deriv likhith-deriv commented Nov 16, 2023 •
edited
Loading

Changes:

The POA form fields in MT5 is not evenly spaced. Making style changes to keep it consistent with POA form under Acount settings
Screenshot 2023-11-17 at 9 10 55 AM

@likhith-deriv likhith-deriv changed the title fix: POA layout for MT5 [COJ]/likhith/[213]-fix: POA layout for MT5 Nov 16, 2023
@vercel
Copy link

vercel bot commented Nov 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 16, 2023 1:00pm

@coveralls
Copy link

coveralls commented Nov 16, 2023 •
edited
Loading

Coverage Status

coverage: 27.762% (-0.01%) from 27.772%
when pulling 50441c1 on likhith-deriv:likhith/COJ-213/fix-poa-mt5-layout
into d35ceb9 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/11502](https://github.com/binary-com/deriv-app/pull/11502)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-likhith-coj-213fix-poa-3884a0.binary.sx?qa_server=red.derivws.com&app_id=38863
    - **Original**: https://deriv-app-git-fork-likhith-deriv-likhith-coj-213fix-poa-3884a0.binary.sx
- **App ID**: `38863`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-coj-213fix-poa-3884a0.binary.sx/

@likhith-deriv likhith-deriv marked this pull request as ready for review November 16, 2023 10:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.9% 0.9% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

⏳ Generating Lighthouse report...

shahzaib-deriv
shahzaib-deriv reviewed Nov 17, 2023
View reviewed changes
packages/core/src/sass/app/_common/components/cfd-poa.scss
.dc-autocomplete {
margin-bottom: 0 !important;
&__form{
padding: 1.6rem 6rem;
Copy link
Contributor

@shahzaib-deriv shahzaib-deriv Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please have a screenshot of the design change as left/right 60px is a lot

Copy link
Contributor Author

@likhith-deriv likhith-deriv Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Styles are just rearranged, the initial styles that were overridden had an effect on dropdown scroll as well. Thought it was not mentioned in the bug. So fixed it with the measurements from the prod

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@likhith-deriv likhith-deriv merged commit 5090ac2 into deriv-com:master Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matin-deriv matin-deriv matin-deriv approved these changes

@amina-deriv amina-deriv amina-deriv approved these changes

@shahzaib-deriv shahzaib-deriv Awaiting requested review from shahzaib-deriv

+2 more reviewers

@yauheni-deriv yauheni-deriv yauheni-deriv approved these changes

@shaheer-deriv shaheer-deriv shaheer-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Account AppStore Core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@likhith-deriv @coveralls @matin-deriv @amina-deriv @yauheni-deriv @shaheer-deriv @shahzaib-deriv