Skip to content

[WALL] Farhan/WALL-2350/Implement useDocumentUploader hook to replace @binary-com/binary-document-uploader library #11600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matin-deriv merged 8 commits into from
Nov 21, 2023
Merged

[WALL] Farhan/WALL-2350/Implement useDocumentUploader hook to replace @binary-com/binary-document-uploader library #11600

matin-deriv merged 8 commits into from
Nov 21, 2023

Conversation

@farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Nov 20, 2023 •
edited
Loading

Changes:

  • Implement function to send binary chunks in useDocumentUpload hook

Screenshots:

Screen.Recording.2023-11-21.at.10.39.43.AM.mov

@farhan-nurzi-deriv farhan-nurzi-deriv requested a review from a user November 20, 2023 15:20
@vercel
Copy link

vercel bot commented Nov 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 21, 2023 7:36am

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/11600](https://github.com/binary-com/deriv-app/pull/11600)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-use-documen-0e5169.binary.sx?qa_server=red.derivws.com&app_id=24096
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-use-documen-0e5169.binary.sx
- **App ID**: `24096`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-use-documen-0e5169.binary.sx/

@coveralls
Copy link

coveralls commented Nov 20, 2023 •
edited
Loading

Coverage Status

coverage: 27.798% (-0.01%) from 27.812%
when pulling e5ea6ad on farhan-nurzi-deriv:farhan/use-document-upload-changes
into e381a2a on binary-com:master.

yashim-deriv
yashim-deriv reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro its 11pm

@farhan-nurzi-deriv farhan-nurzi-deriv changed the title [WALL] Farhan/useDocumentUpload hook completion [WALL] Farhan/WALL-2680/useDocumentUpload hook completion Nov 21, 2023
@farhan-nurzi-deriv farhan-nurzi-deriv changed the title [WALL] Farhan/WALL-2680/useDocumentUpload hook completion [WALL] Farhan/WALL-2350/useDocumentUpload hook completion Nov 21, 2023
@farhan-nurzi-deriv farhan-nurzi-deriv changed the title [WALL] Farhan/WALL-2350/useDocumentUpload hook completion [WALL] Farhan/WALL-2350/Implement useDocumentUploader hook to replace @binary-com/binary-document-uploader library Nov 21, 2023
matin-deriv
matin-deriv reviewed Nov 21, 2023
View reviewed changes
yashim-deriv
yashim-deriv previously approved these changes Nov 21, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
5.3% 5.3% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023

🚀 Smoke test run (2) passed successfully!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023

🚀 Smoke test run (1) passed successfully!

@matin-deriv matin-deriv merged commit bf14cc3 into deriv-com:master Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matin-deriv matin-deriv matin-deriv approved these changes

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@aizad-deriv aizad-deriv Awaiting requested review from aizad-deriv

@heorhi-deriv heorhi-deriv Awaiting requested review from heorhi-deriv

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@farhan-nurzi-deriv @coveralls @matin-deriv @yashim-deriv @Farhan-slurrp