Skip to content

Conversation

shontzu-deriv
Copy link
Contributor

@shontzu-deriv shontzu-deriv commented Nov 22, 2023

Changes:

  • CU
  • Derived jurisdiction modal and Financial jurisdiction modal should have their own height due to content difference to prevent extra spaces or scrolling content
  • the "Next" button size issue is handled in this card

Screenshots:

image image

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 22, 2023 5:46am

Copy link

gitguardian bot commented Nov 22, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 42dfe48 nx.json View secret
- Generic High Entropy Secret 4c21100 nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented Nov 22, 2023

Coverage Status

coverage: 28.107%. remained the same
when pulling 4cd69ee on shontzu-deriv:shontzu/CFDS-1322/space-in-derived-jurisdiction-modal
into 9e82f3c on binary-com:master.

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-1322space-b3aa72.binary.sx/

Copy link
Contributor

github-actions bot commented Nov 22, 2023

Generating Lighthouse report...

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@shontzu-deriv shontzu-deriv changed the title Shontzu/cfds 1322/space in derived jurisdiction modal Shontzu/cfds 1322/space in synthetic jurisdiction modal Nov 22, 2023
@shontzu-deriv
Copy link
Contributor Author

Closing this due to testlink not generating for having the word 'deriv' in the pr link

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants