Skip to content

[WALL] Fix next button onfido disabled and added success screen #11655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 22, 2023
Merged

[WALL] Fix next button onfido disabled and added success screen #11655

merged 8 commits into from
Nov 22, 2023

Conversation

@adrienne-deriv
Copy link
Contributor

@adrienne-deriv adrienne-deriv commented Nov 22, 2023

Changes:

Please provide a summary of the change.

  • Added a success screen when Onfido submission is successful
  • Disabled next button when Onfido is not yet submitted
Screenshot 2023-11-22 at 1 14 18 PM

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Nov 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 22, 2023 6:10am

@adrienne-deriv adrienne-deriv marked this pull request as ready for review November 22, 2023 05:37
@adrienne-deriv adrienne-deriv requested a review from a user November 22, 2023 05:37
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/11655](https://github.com/binary-com/deriv-app/pull/11655)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-fix-next-button-onfido.binary.sx?qa_server=red.derivws.com&app_id=24048
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-fix-next-button-onfido.binary.sx
- **App ID**: `24048`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-fix-next-button-onfido.binary.sx/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.6% 4.6% Duplication

@coveralls
Copy link

coveralls commented Nov 22, 2023 •
edited
Loading

Coverage Status

coverage: 28.102% (-0.005%) from 28.107%
when pulling b14ce31 on adrienne-deriv:fix-next-button-onfido
into 9e82f3c on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023

🚀 Smoke test run (1) passed successfully!

@matin-deriv matin-deriv merged commit 1049873 into deriv-com:master Nov 22, 2023
lubega-deriv
lubega-deriv reviewed Nov 22, 2023
View reviewed changes
packages/wallets/src/features/cfd/screens/Onfido/Onfido.tsx
Comment on lines +4 to +5
import { useFlow } from '../../../../components/FlowProvider';
import { WalletsActionScreen } from '../../../../components/WalletsActionScreen';
Copy link
Contributor

@lubega-deriv lubega-deriv Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question but couldn't these imports be combined under ../../../../components?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matin-deriv matin-deriv matin-deriv approved these changes

@farhan-nurzi-deriv farhan-nurzi-deriv Awaiting requested review from farhan-nurzi-deriv

@heorhi-deriv heorhi-deriv Awaiting requested review from heorhi-deriv

+3 more reviewers

@lubega-deriv lubega-deriv lubega-deriv left review comments

@aizad-deriv aizad-deriv aizad-deriv approved these changes

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adrienne-deriv @coveralls @matin-deriv @aizad-deriv @thisyahlen-deriv @lubega-deriv