[WALL] Aizad/WALL-2637/password-validation-issue #11657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated WalletPasswordField by using third party lib - WalletPasswordField has new error message and new scoring system - updated HelperMessage by accepting variants - created hook for PasswordValidation
…WALL-2637/password-input-mod
- move regex values to constant file - seperate hook funtionality - resolve comments
- make usePasswordValidation into a util function - make change accordingly based on the changes - remove usePasswordValidation hook
…WALL-2637/password-input-mod
aizad-deriv
requested review from
adrienne-deriv,
farhan-nurzi-deriv and
thisyahlen-deriv
as code owners
aizad-deriv
requested review from
ali-hosseini-deriv,
balakrishna-deriv,
heorhi-deriv,
maryia-deriv,
matin-deriv and
yashim-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Contributor
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wall-2637password-v-4dafba.binary.sx/ |
lubega-deriv
approved these changes
Nov 22, 2023
farhan-nurzi-deriv
previously approved these changes
Nov 22, 2023
ghost
reviewed
Nov 22, 2023
ghost
previously approved these changes
Nov 22, 2023
aizad-deriv
dismissed stale reviews from ghost
and thisyahlen-deriv
via
a224268
packages/wallets/src/components/Base/WalletPasswordField/WalletPasswordField.scss
Outdated
Show resolved
Hide resolved
packages/wallets/src/components/Base/WalletTextField/HelperMessage.tsx
Outdated
Show resolved
Hide resolved
yashim-deriv
previously approved these changes
Nov 23, 2023
Contributor
|
🚀 Smoke test run (2) passed successfully! |
Contributor
|
🚀 Smoke test run (2) passed successfully! |
Contributor
|
🚀 Smoke test run (1) passed successfully! |
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
🚀 Smoke test run (1) passed successfully! |
Contributor
|
🚀 Smoke test run (2) passed successfully! |
mahdiyeh-deriv
approved these changes
Nov 23, 2023
Contributor
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
Contributor
|
⏳ Generating Lighthouse report... |
farhan-nurzi-deriv
approved these changes
Nov 23, 2023
matin-deriv
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Password Validation behaviour to match with Production.
Changes:
passwordUtilsandpasswordConstantsto have password validation functionalities.PasswordFieldUtils<HelperMessage />to show messages in different colorsScreenshots:
Screen.Recording.2023-11-21.at.4.03.19.PM.mov