Skip to content

[WALL] Farhan/WALL-2152/Manual Upload Flow #11667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 23, 2023
Merged

[WALL] Farhan/WALL-2152/Manual Upload Flow #11667

merged 10 commits into from
Nov 23, 2023

Conversation

@farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Nov 22, 2023

Changes:

Complete manual upload flow

Screenshots:

Screenshot 2023-11-22 at 4 03 18 PM
Screen.Recording.2023-11-22.at.4.01.19.PM.mov

@farhan-nurzi-deriv farhan-nurzi-deriv requested a review from a user November 22, 2023 08:10
@vercel
Copy link

vercel bot commented Nov 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 23, 2023 5:33am

aizad-deriv
aizad-deriv previously approved these changes Nov 22, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/11667](https://github.com/binary-com/deriv-app/pull/11667)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-manual-upload-flow.binary.sx?qa_server=red.derivws.com&app_id=23833
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-manual-upload-flow.binary.sx
- **App ID**: `23833`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-manual-upload-flow.binary.sx/

@coveralls
Copy link

coveralls commented Nov 22, 2023 •
edited
Loading

Coverage Status

coverage: 28.196% (+0.007%) from 28.189%
when pulling f86b506 on farhan-nurzi-deriv:farhan/manual-upload-flow
into ba632d7 on binary-com:master.

rostislav-deriv
rostislav-deriv approved these changes Nov 22, 2023
View reviewed changes
yashim-deriv
yashim-deriv reviewed Nov 23, 2023
View reviewed changes
adrienne-deriv
adrienne-deriv reviewed Nov 23, 2023
View reviewed changes
adrienne-deriv
adrienne-deriv suggested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

adrienne-deriv
adrienne-deriv approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.9% 5.9% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023

🚀 Smoke test run (2) passed successfully!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023

🚀 Smoke test run (1) passed successfully!

@yashim-deriv yashim-deriv merged commit 424a164 into deriv-com:master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@heorhi-deriv heorhi-deriv Awaiting requested review from heorhi-deriv

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@matin-deriv matin-deriv Awaiting requested review from matin-deriv

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv

@amina-deriv amina-deriv Awaiting requested review from amina-deriv

+3 more reviewers

@adrienne-deriv adrienne-deriv adrienne-deriv approved these changes

@rostislav-deriv rostislav-deriv rostislav-deriv approved these changes

@aizad-deriv aizad-deriv aizad-deriv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@farhan-nurzi-deriv @coveralls @yashim-deriv @adrienne-deriv @aizad-deriv @rostislav-deriv @Farhan-slurrp