Skip to content

Conversation

maryia-matskevich-deriv
Copy link
Contributor

Changes:

duration field validation error is not displayed in mobile

Screenshots:

Screen.Recording.2023-11-23.at.14.41.28.mov

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 23, 2023 0:20am

@coveralls
Copy link

coveralls commented Nov 23, 2023

Coverage Status

coverage: 28.169% (+0.002%) from 28.167%
when pulling 6666878 on maryia-matskevich-deriv:maryia/WEBREL-1698
into 10ec9c9 on binary-com:master.

Copy link
Contributor

github-actions bot commented Nov 23, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11714](https://github.com/binary-com/deriv-app/pull/11714)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-webrel-1698.binary.sx?qa_server=red.derivws.com&app_id=32877
    - **Original**: https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-webrel-1698.binary.sx
- **App ID**: `32877`

Copy link
Contributor

github-actions bot commented Nov 23, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-webrel-1698.binary.sx/

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
33.4% 33.4% Duplication

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

Generating Lighthouse report...

@likhith-deriv likhith-deriv merged commit d768157 into deriv-com:master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants