Skip to content

Conversation

@markw-deriv
Copy link
Contributor

Remove the landscape ui blocker:

Screenshot 2023-11-27 at 10 19 24

@vercel
Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 26, 2024 9:46am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@markw-deriv markw-deriv changed the title chore: remove landscape ui blocker [FEQ] chore: remove landscape ui blocker Nov 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11798](https://github.com/binary-com/deriv-app/pull/11798)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-markwylde-deriv-remove-landscape-ui-blocker.binary.sx?qa_server=red.derivws.com&app_id=32484
    - **Original**: https://deriv-app-git-fork-markwylde-deriv-remove-landscape-ui-blocker.binary.sx
- **App ID**: `32484`

@coveralls
Copy link

coveralls commented Nov 27, 2023

Coverage Status

coverage: 34.89%. remained the same
when pulling 59028f8 on markwylde-deriv:remove-landscape-ui-blocker
into 0221e8f on binary-com:master.

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 17
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-markwylde-deriv-remove-landscape-ui-blocker.binary.sx/

Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI seems to be broken @markwylde-deriv

Screenshot 2023-12-26 at 4 25 21 PM

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
4.9% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 27, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed.

@github-actions github-actions bot closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants