Skip to content

Conversation

@rostislav-deriv
Copy link
Contributor

@rostislav-deriv rostislav-deriv commented Nov 29, 2023

Changes:

  • rename useTransactions to useInfiniteTransactions
  • add new hook useTransactions which is a statement call wrapper as well, but w/o pagination / lazy data loading, unlike useInfiniteTransactions
  • create new component for reset_balance transactions of demo wallets which only requests for deposit and withdrawal transactions, merges and sorts them by time, and renders

Screenshots:

Screen.Recording.2023-11-29.at.16.45.17.mov

@vercel
Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 29, 2023 1:59pm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11880](https://github.com/binary-com/deriv-app/pull/11880)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rostislav-deriv-rostislav-demo-transa-9f257f.binary.sx?qa_server=red.derivws.com&app_id=31478
    - **Original**: https://deriv-app-git-fork-rostislav-deriv-rostislav-demo-transa-9f257f.binary.sx
- **App ID**: `31478`

@coveralls
Copy link

coveralls commented Nov 29, 2023

Coverage Status

coverage: 28.96% (-0.03%) from 28.985%
when pulling a0b7607 on rostislav-deriv:rostislav/demo-transactions-workaround
into ee40541 on binary-com:master.

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-rostislav-deriv-rostislav-demo-transa-9f257f.binary.sx/

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

Generating Lighthouse report...

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving heavy-hearted as clearly this is us overcoming backend limitations

@heorhi-deriv heorhi-deriv merged commit 0b7b8e9 into deriv-com:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants