Skip to content

Conversation

@thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Add temporary language panel for language switching in wallets

Screenshots:

Screenshot 2023-11-30 at 2 30 24 PM

@vercel
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 30, 2023 7:26am

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11902](https://github.com/binary-com/deriv-app/pull/11902)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-languagep-f93ae4.binary.sx?qa_server=red.derivws.com&app_id=23815
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-languagep-f93ae4.binary.sx
- **App ID**: `23815`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-languagep-f93ae4.binary.sx/

Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Nov 30, 2023

Coverage Status

coverage: 29.019% (-0.007%) from 29.026%
when pulling 83cec0e on thisyahlen-deriv:thisyahlen/language_panel_for_wallets
into 2429586 on binary-com:master.

@github-actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@yashim-deriv yashim-deriv merged commit 1c7c150 into deriv-com:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants