Skip to content

[BOT] Farabi/bot-968/stop bot modal content test case #11953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 6, 2023
Merged

[BOT] Farabi/bot-968/stop bot modal content test case #11953

merged 5 commits into from
Dec 6, 2023

Conversation

farabi-deriv
Copy link
Contributor

Changes:

  • Added test case for rendering stop-bot-modal-content

Screenshots:

Screenshot 2023-12-01 at 4 31 12 PM

@boring-cyborg boring-cyborg bot added the Bot label Dec 1, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 5, 2023 5:15am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/11953](https://github.com/binary-com/deriv-app/pull/11953)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-968stop-bot-m-b6bd71.binary.sx?qa_server=red.derivws.com&app_id=30361
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-968stop-bot-m-b6bd71.binary.sx
- **App ID**: `30361`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 85
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-968stop-bot-m-b6bd71.binary.sx/

@coveralls
Copy link

coveralls commented Dec 1, 2023 •
edited
Loading

Coverage Status

coverage: 29.718% (+0.01%) from 29.705%
when pulling 008adbc on farabi-deriv:farabi/bot-968/stop-bot-modal-content-test-case
into 9bec43c on binary-com:master.

@shafin-deriv
Copy link
Contributor

@farabi-deriv there is a conditional render check based on the value of these two props is_running & is_multiplier. So can you at least write 2 different test cases for this?

@maryia-matskevich-deriv
Copy link
Contributor

everything is fine👍
but one thing has missed:
Screenshot 2023-12-04 at 19 56 18

@farabi-deriv
Copy link
Contributor Author

@maryia-matskevich-deriv I've run the test and it shows that the file is completely covered on the test

Screenshot 2023-12-05 at 12 56 04 PM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.9% 4.9% Duplication

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023 •
edited
Loading

⏳ Generating Lighthouse report...

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@sandeep-deriv sandeep-deriv merged commit eda9b80 into deriv-com:master Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rupato-deriv rupato-deriv rupato-deriv approved these changes

@prince-deriv prince-deriv Awaiting requested review from prince-deriv

@vinu-deriv vinu-deriv Awaiting requested review from vinu-deriv

+3 more reviewers

@suisin-deriv suisin-deriv suisin-deriv left review comments

@sandeep-deriv sandeep-deriv sandeep-deriv approved these changes

@shafin-deriv shafin-deriv shafin-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@farabi-deriv @coveralls @shafin-deriv @maryia-matskevich-deriv @sandeep-deriv @rupato-deriv @suisin-deriv