Skip to content

Conversation

@balakrishna-deriv
Copy link
Contributor

Changes:

Updates the Smartcharts npm version to fix the separator lines appearing on each day when the chart is zoomed out.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 5, 2023 10:38am

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12022](https://github.com/binary-com/deriv-app/pull/12022)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-balakrishna-deriv-update-charts-version-16.binary.sx?qa_server=red.derivws.com&app_id=23848
    - **Original**: https://deriv-app-git-fork-balakrishna-deriv-update-charts-version-16.binary.sx
- **App ID**: `23848`

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 85
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-balakrishna-deriv-update-charts-version-16.binary.sx/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.6% 7.6% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@coveralls
Copy link

Coverage Status

coverage: 29.73%. remained the same
when pulling 4706344 on balakrishna-deriv:update-charts-version-16
into e775809 on binary-com:master.

@heorhi-deriv heorhi-deriv merged commit b6c76c6 into deriv-com:master Dec 5, 2023
heorhi-deriv pushed a commit that referenced this pull request Dec 5, 2023
hamza-deriv added a commit that referenced this pull request Dec 6, 2023
hamza-deriv added a commit that referenced this pull request Dec 6, 2023
hamza-deriv added a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants