-
Notifications
You must be signed in to change notification settings - Fork 394
chore: remove the built icons file from git #12102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Kudos, SonarCloud Quality Gate passed! |
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-markwylde-deriv-remove-icons-from-git.binary.sx/ |
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
|
⏳ Generating Lighthouse report... |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed. |








As the
packages/components/stories/icon/icons.jsfile is generated during build, it shouldn't be commited to the git file, just like binarys and the dist folder.This PR removes the file and add's it to the gitignore file.
It should stop the
packages/components/stories/icon/icons.jsconstantly being changes from the master branch on build.