Skip to content

Conversation

@markw-deriv
Copy link
Contributor

@markw-deriv markw-deriv commented Dec 7, 2023

As the packages/components/stories/icon/icons.js file is generated during build, it shouldn't be commited to the git file, just like binarys and the dist folder.

This PR removes the file and add's it to the gitignore file.

It should stop the packages/components/stories/icon/icons.js constantly being changes from the master branch on build.

@vercel
Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 7, 2023 11:21am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12102](https://github.com/binary-com/deriv-app/pull/12102)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-markwylde-deriv-remove-icons-from-git.binary.sx?qa_server=red.derivws.com&app_id=32870
    - **Original**: https://deriv-app-git-fork-markwylde-deriv-remove-icons-from-git.binary.sx
- **App ID**: `32870`

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-markwylde-deriv-remove-icons-from-git.binary.sx/

@coveralls
Copy link

coveralls commented Dec 7, 2023

Coverage Status

coverage: 29.777%. remained the same
when pulling 7692686 on markwylde-deriv:remove-icons-from-git
into 36898d7 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Generating Lighthouse report...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 7, 2024
@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed.

@github-actions github-actions bot closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants